Skip to content

[BugFix] Bug fixes in modifiers - #667

Merged
adamdempsey90 merged 7 commits into
mainfrom
dempsey/modifiers_fix
Nov 7, 2026
Merged

adamdempsey90 merged 7 commits into
mainfrom
dempsey/modifiers_fix

Conversation

@adamdempsey90

Copy link
Copy Markdown
Collaborator

PR Summary

Sol identified bugs in the modifier implementations. Adds new tests for them.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI
  • If ML was used, make sure to add a disclaimer at the top of a file indicating ML was used to assist in generating the file.
  • If Agentic AI was used, have the AI generate a "proposed changes" markdown file and store it in the plan_histories folder, with a filename the same as the MR number.

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Maintainers: ensure spackages are up to date:
    • LANL-internal team, update XCAP spackages
    • Current maintainer of upstream spackages, submit MR to spack

@Yurlungur Yurlungur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning these up!

@Yurlungur

Copy link
Copy Markdown
Collaborator

Tests failing though

@adamdempsey90
adamdempsey90 marked this pull request as ready for review November 6, 2026 23:52
@adamdempsey90

Copy link
Copy Markdown
Collaborator Author

Tests look good now, merging

@adamdempsey90
adamdempsey90 merged commit 7b9efe0 into main Nov 7, 2026
10 checks passed
@adamdempsey90
adamdempsey90 deleted the dempsey/modifiers_fix branch November 7, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants